fix(block-producer): handle reverted batches #557
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mirko-von-Leipzig
force-pushed
the
mirko/fix/mempool-reverts
branch
from
7e1761b to
9076e33
Compare
Mirko-von-Leipzig
force-pushed
the
mirko/fix/mempool-reverts
branch
from
9076e33 to
a825ade
Compare
Mirko-von-Leipzig
changed the title
Mirko-von-Leipzig
changed the title
bobbinth
approved these changes
Dec 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR corrects the mempool's behaviour when batches are reverted.
More concretely, it fixes an issue where a child batch jobs weren't invalidated when their parent batch was reverted. This is fixed by actively tracking inflight batch jobs, and ignoring submitted jobs not part of this list.