ci: fix deploy workflow #567
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mirko-von-Leipzig
force-pushed
the
mirko/fix/deploy_script
branch
3 times, most recently
from
7d1fe21 to
c8b06ea
Compare
Mirko-von-Leipzig
force-pushed
the
mirko/fix/deploy_script
branch
from
c8b06ea to
03416a4
Compare
|
@Mirko-von-Leipzig - what's remaining to do to merge this? |
Nothing I just need an approval :) |
bobbinth
approved these changes
Jan 6, 2025
Correct yes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes some issues picked up when deploying a non-release version.
Non-release deployments requires building the packages as part of the workflow. Release deployments simply pull the pre-built binaries from github directly. Non-release deployments haven't been exercised fully before.
More concretely this PR fixes: