Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: enforce unique account prefix #604

Open
wants to merge 2 commits into
base: next
Choose a base branch
from

Conversation

tomyrd
Copy link
Collaborator

@tomyrd tomyrd commented Dec 30, 2024

closes #601

@tomyrd tomyrd marked this pull request as ready for review December 30, 2024 19:05
@bobbinth
Copy link
Contributor

bobbinth commented Jan 5, 2025

Not a review yet - but one thing I'm wondering is whether we should tackle this issue in a broader context. Specifically, currently account tree uses a SimpleSmt and so the methodology for checking uniqueness relies on this. But it is probably a good idea to migrate from SimpleSmt to a regular Smt - and in this case, we probably would need to modify the approach somewhat.

We should still weigh all pros and cons of migrating from SimpleSmt to Smt - but it may make sense to put this PR on hold until we make a decision here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants