Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci(deploy): fix gitref typo and simplify package directory creation #605

Merged
merged 2 commits into from
Jan 10, 2025
Merged

ci(deploy): fix gitref typo and simplify package directory creation #605

merged 2 commits into from
Jan 10, 2025

Conversation

crStiv
Copy link
Contributor

@crStiv crStiv commented Jan 8, 2025 •
edited
Loading

  • Fix typo in gitref variable name
  • Add missing colons in error message syntax
  • Refactor directory creation using loop to reduce code duplication

Mirko-von-Leipzig
Mirko-von-Leipzig requested changes Jan 9, 2025
View reviewed changes
Copy link
Contributor

@Mirko-von-Leipzig Mirko-von-Leipzig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks I was wondering why commit based deploys weren't working :D

Just the one minor whitespace fixup then we're good to go.

.github/actions/build_package/action.yml Outdated Show resolved Hide resolved
@Mirko-von-Leipzig Mirko-von-Leipzig changed the title fix: optimize directory creation and fix gitref typo ci: optimize directory creation and fix gitref typo Jan 9, 2025
@Mirko-von-Leipzig Mirko-von-Leipzig changed the title ci: optimize directory creation and fix gitref typo ci: fix gitref typo and simplify package directory creation Jan 9, 2025
@crStiv
Copy link
Contributor Author

crStiv commented Jan 9, 2025

@Mirko-von-Leipzig update done

@Mirko-von-Leipzig Mirko-von-Leipzig changed the title ci: fix gitref typo and simplify package directory creation ci(deploy): fix gitref typo and simplify package directory creation Jan 10, 2025
@Mirko-von-Leipzig Mirko-von-Leipzig merged commit b16b9ee into 0xPolygonMiden:main Jan 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mirko-von-Leipzig Mirko-von-Leipzig Mirko-von-Leipzig approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@crStiv @Mirko-von-Leipzig