add basic block merging threshold #1461
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a threshold when merging basic blocks after which we won't merge more blocks in.
Benchmarks for 2 different values (quite similar):
next
:MAX_OPERATIONS_PER_BASIC_BLOCK_WHEN_MERGING = 1000
:MAX_OPERATIONS_PER_BASIC_BLOCK_WHEN_MERGING = 2500
:Note that
deserialize_std_lib
time is directly proportional to the size of the stdlib serialized binary. So with the constant at1000
or2500
, it roughly halves the size of the binary (i.e. ~0.6MB).