Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix trace lengths #110

Merged
merged 1 commit into from
Mar 18, 2024
Merged

Fix trace lengths #110

merged 1 commit into from
Mar 18, 2024

Conversation

hratoanina
Copy link
Contributor

The unpadded Memory length doesn't reflect the true length, since it doesn't include MemBefore or the filling ops.
We also now display the unpadded length of MemBefore and MemAfter.

@github-actions github-actions bot added the crate: evm_arithmetization Anything related to the evm_arithmetization crate. label Mar 15, 2024
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Copy link
Collaborator

@Nashtare Nashtare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hratoanina hratoanina merged commit 39bf13b into feat/continuations Mar 18, 2024
7 checks passed
@hratoanina hratoanina deleted the fix_trace_lengths branch March 18, 2024 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
crate: evm_arithmetization Anything related to the evm_arithmetization crate.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants