Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

continuations: Remove redundant simulation #203

Merged
merged 6 commits into from
Apr 30, 2024

Conversation

Nashtare
Copy link
Collaborator

Calling simulate_all_segments_interpreter would always start from index = 0 up to the targeted segment.
Additionally, this refactors a bit segment generation.

@Nashtare Nashtare added this to the zk-continuations - Q2 2024 milestone Apr 30, 2024
@Nashtare Nashtare requested a review from LindaGuiga April 30, 2024 20:35
@Nashtare Nashtare self-assigned this Apr 30, 2024
@github-actions github-actions bot added the crate: evm_arithmetization Anything related to the evm_arithmetization crate. label Apr 30, 2024
Copy link
Contributor

@LindaGuiga LindaGuiga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks!

evm_arithmetization/src/prover.rs Outdated Show resolved Hide resolved
@Nashtare Nashtare merged commit 2df4454 into feat/continuations Apr 30, 2024
6 checks passed
@Nashtare Nashtare deleted the redundant-simulation branch April 30, 2024 22:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
crate: evm_arithmetization Anything related to the evm_arithmetization crate.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants