Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

implement version command for all zero bin binaries #451

Merged
merged 11 commits into from
Aug 6, 2024
Merged

implement version command for all zero bin binaries #451

merged 11 commits into from
Aug 6, 2024

Conversation

temaniarpit27
Copy link
Contributor

@temaniarpit27 temaniarpit27 commented Jul 29, 2024 •
edited
Loading

This PR ads cmd args version for getting the version info for zero-bin binaries
Usage:

./verifier --version
./leader --version
./rpc --version
./worker --version

Expected Resp:

evm_arithmetization Package Version: 0.4.x
Build Commit Hash: fbccf50533b1f287edccb1fc0dd847cd78a1a27e
Build Timestamp: 2024-08-01T06:26:33.843694000Z

@temaniarpit27 temaniarpit27 requested a review from 0xaatif July 29, 2024 04:42
@github-actions github-actions bot added the crate: zero_bin Anything related to the zero-bin subcrates. label Jul 29, 2024
@temaniarpit27 temaniarpit27 requested a review from atanmarko July 29, 2024 04:49
atanmarko
atanmarko reviewed Jul 29, 2024
View reviewed changes
zero_bin/leader/src/main.rs Outdated Show resolved Hide resolved
zero_bin/rpc/Cargo.toml Outdated Show resolved Hide resolved
atanmarko
atanmarko reviewed Jul 29, 2024
View reviewed changes
zero_bin/rpc/src/main.rs Outdated Show resolved Hide resolved
atanmarko
atanmarko reviewed Jul 29, 2024
View reviewed changes
zero_bin/common/src/prover_state/persistence.rs Outdated Show resolved Hide resolved
zero_bin/leader/src/main.rs Outdated Show resolved Hide resolved
zero_bin/common/src/version.rs Outdated Show resolved Hide resolved
@temaniarpit27 temaniarpit27 force-pushed the arpit/424 branch 2 times, most recently from efcea57 to f9dcab6 Compare July 29, 2024 13:23
@atanmarko
Copy link
Member

atanmarko commented Jul 29, 2024 •
edited
Loading

I am good with the PR in general

EDIT: let's discuss worker and verifier subcommand version solution further.

Nashtare
Nashtare requested changes Jul 29, 2024
View reviewed changes
zero_bin/README.md Outdated Show resolved Hide resolved
zero_bin/README.md Outdated Show resolved Hide resolved
zero_bin/README.md Outdated Show resolved Hide resolved
zero_bin/common/src/version.rs Outdated Show resolved Hide resolved
zero_bin/leader/Cargo.toml Outdated Show resolved Hide resolved
zero_bin/rpc/Cargo.toml Outdated Show resolved Hide resolved
zero_bin/verifier/Cargo.toml Outdated Show resolved Hide resolved
zero_bin/worker/Cargo.toml Outdated Show resolved Hide resolved
muursh and others added 2 commits July 31, 2024 08:39
Nashtare
Nashtare reviewed Aug 1, 2024
View reviewed changes
Cargo.toml Outdated Show resolved Hide resolved
muursh
muursh reviewed Aug 2, 2024
View reviewed changes
zero_bin/leader/src/main.rs Outdated Show resolved Hide resolved
@muursh
Copy link
Contributor

muursh commented Aug 5, 2024

@temaniarpit27 you have some clippy issues. Can you address those?

@temaniarpit27
Copy link
Contributor Author

@temaniarpit27 you have some clippy issues. Can you address those?

I am not sure how are these coming. I havent changed anything around it. Let me check by retrying it

@github-actions github-actions bot added the crate: trace_decoder Anything related to the trace_decoder crate. label Aug 5, 2024
@temaniarpit27 temaniarpit27 changed the base branch from develop to arpit/fix-develop August 5, 2024 12:11
@temaniarpit27 temaniarpit27 changed the base branch from arpit/fix-develop to develop August 6, 2024 05:07
muursh
muursh approved these changes Aug 6, 2024
View reviewed changes
Copy link
Contributor

@muursh muursh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine by me

@muursh muursh mentioned this pull request Aug 6, 2024
Merged
@Nashtare Nashtare added this to the System strengthening milestone Aug 6, 2024
@Nashtare Nashtare linked an issue Aug 6, 2024 that may be closed by this pull request
Add version CLI information for zero-bin binaries #424
Closed
@Nashtare Nashtare merged commit 52ab1aa into develop Aug 6, 2024
15 checks passed
@Nashtare Nashtare deleted the arpit/424 branch August 6, 2024 15:57
@0xaatif 0xaatif mentioned this pull request Sep 17, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@atanmarko atanmarko atanmarko left review comments

@muursh muursh muursh approved these changes

@Nashtare Nashtare Nashtare approved these changes

@0xaatif 0xaatif Awaiting requested review from 0xaatif 0xaatif is a code owner

Assignees

@temaniarpit27 temaniarpit27

Labels
crate: trace_decoder Anything related to the trace_decoder crate. crate: zero_bin Anything related to the zero-bin subcrates.
Projects
Zero EVM
Status: Done
Milestone
System strengthening
Development

Successfully merging this pull request may close these issues.

Add version CLI information for zero-bin binaries
4 participants
@temaniarpit27 @atanmarko @muursh @Nashtare