Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: use eth_call with sc to retrieve block hashes #519

Merged
merged 2 commits into from
Aug 27, 2024
Merged

feat: use eth_call with sc to retrieve block hashes #519

merged 2 commits into from
Aug 27, 2024

Conversation

atanmarko
Copy link
Member

@atanmarko atanmarko commented Aug 20, 2024 •
edited
Loading

Resolves #510

@atanmarko atanmarko self-assigned this Aug 20, 2024
@github-actions github-actions bot added the crate: zero_bin Anything related to the zero-bin subcrates. label Aug 20, 2024
@atanmarko atanmarko marked this pull request as ready for review August 20, 2024 20:09
@Nashtare Nashtare added this to the System strengthening milestone Aug 21, 2024
@atanmarko atanmarko force-pushed the feat/previous-hashes-with-smart-contract branch from 5d695b3 to 260e2e4 Compare August 22, 2024 11:33
Nashtare
Nashtare reviewed Aug 22, 2024
View reviewed changes
zero_bin/rpc/src/lib.rs Show resolved Hide resolved
zero_bin/rpc/src/lib.rs Show resolved Hide resolved
zero_bin/rpc/src/lib.rs Outdated Show resolved Hide resolved
zero_bin/rpc/src/lib.rs Outdated Show resolved Hide resolved
@atanmarko atanmarko force-pushed the feat/previous-hashes-with-smart-contract branch from 52f00d6 to f4aa677 Compare August 23, 2024 08:41
@atanmarko atanmarko force-pushed the feat/previous-hashes-with-smart-contract branch from f4aa677 to 44a9cd5 Compare August 23, 2024 08:44
Nashtare
Nashtare approved these changes Aug 26, 2024
View reviewed changes
Copy link
Collaborator

@Nashtare Nashtare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, although I havent actually tested the functionality w.r.t #510

@atanmarko atanmarko merged commit 85ef4ec into develop Aug 27, 2024
15 checks passed
@atanmarko atanmarko deleted the feat/previous-hashes-with-smart-contract branch August 27, 2024 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@muursh muursh muursh approved these changes

@Nashtare Nashtare Nashtare approved these changes

@praetoriansentry praetoriansentry Awaiting requested review from praetoriansentry

Assignees

@atanmarko atanmarko

Labels
crate: zero_bin Anything related to the zero-bin subcrates.
Projects
Zero EVM
Status: Done
Milestone
System strengthening
Development

Successfully merging this pull request may close these issues.

Implement rpc batch request for previous block hash retrieval
3 participants
@atanmarko @muursh @Nashtare