feat: add consolidated block hashes across checkpoints #551
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nashtare
requested review from
0xaatif,
muursh,
atanmarko and
LindaGuiga
as code owners
github-actions
bot
added
crate: trace_decoder
Nashtare
changed the title
0xaatif
approved these changes
Aug 27, 2024
| use processed_block_trace::ProcessedTxnInfo; | ||
| use serde::{Deserialize, Serialize}; | ||
| use typed_mpt::{StateTrie, StorageTrie, TrieKey}; | ||
|
|
||
| /// The base field on which statements are being proven. | ||
| // TODO(Robin): https://github.com/0xPolygonZero/zk_evm/issues/531 | ||
| pub type Field = GoldilocksField; |
There was a problem hiding this comment.
very nit/style:
I think this could be confusing because it's name collides with a type parameter name:
type Inner = u8;
struct Foo<Inner>(Inner);When I see Foo<Inner>, is it like Vec<u8> or Vec<T>.
I prefer to use T as a suffix for actually descriptive type parameters.
type Field = GoldilocksField.
struct Foo<FieldT>(FieldT);
Nashtare
force-pushed
the
feat/consolidated_hashes
branch
from
ddb13ea to
5a12444
Compare
Nashtare
force-pushed
the
feat/consolidated_hashes
branch
from
46b9656 to
9207ff0
Compare
hratoanina
approved these changes
Sep 12, 2024
| @@ -368,10 +450,13 @@ impl BlockMetadata { | |||
|
|
|||
| /// Additional block data that are specific to the local transaction being | |||
There was a problem hiding this comment.
Nit: they aren't all local to the transaction anymore.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Built on top of #526
Adds additional connection across checkpoints for the previous block hashes.
Notes:
Field->RichFieldis also necessary for the type2 anyway, so harmless in this regard.Hasher/Fieldwe're using, and keep the information at the level ofevm_arithmetization, while also doing part of move constants fromevm_arithmetizationtocommon#531 which is more widespread than I thought.