Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix clean leader's command #586

Merged
merged 2 commits into from
Sep 4, 2024
Merged

Fix clean leader's command #586

merged 2 commits into from
Sep 4, 2024

Conversation

Nashtare
Copy link
Collaborator

@Nashtare Nashtare commented Sep 4, 2024 •
edited
Loading

This:

  • makes sure to trim the directory path prefix (by considering only the actual filename) to search for matches
  • run the clean command ahead of config and runtime creation, to not have to pass any additional arguments nor go through needless preprocessing if calling clean with an actual missing permutation of ranges.

Tested on macbook M2 pro and Ubuntu 22.04.

@Nashtare Nashtare self-assigned this Sep 4, 2024
@Nashtare Nashtare added this to the x Misc. milestone Sep 4, 2024
@github-actions github-actions bot added the crate: zero_bin Anything related to the zero-bin subcrates. label Sep 4, 2024
atanmarko
atanmarko approved these changes Sep 4, 2024
View reviewed changes
zero_bin/leader/src/main.rs Outdated Show resolved Hide resolved
@Nashtare Nashtare merged commit bbfc0f4 into develop Sep 4, 2024
15 checks passed
@Nashtare Nashtare deleted the fix/clean_command branch September 4, 2024 14:23
einar-polygon
einar-polygon approved these changes Sep 4, 2024
View reviewed changes
Copy link
Contributor

@einar-polygon einar-polygon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just ran this on Linux and it clears out ~/.cache/zk_evm_circuit_cache/ as expected.

lgtm.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@atanmarko atanmarko atanmarko approved these changes

@einar-polygon einar-polygon einar-polygon approved these changes

@muursh muursh Awaiting requested review from muursh

Assignees

@Nashtare Nashtare

Labels
crate: zero_bin Anything related to the zero-bin subcrates.
Projects
Zero EVM
Status: Done
Milestone
x Misc.
Development

Successfully merging this pull request may close these issues.
3 participants
@Nashtare @atanmarko @einar-polygon