Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix decoder parsing with new storage tries #692

Merged
merged 1 commit into from
Oct 3, 2024
Merged

Conversation

Nashtare
Copy link
Collaborator

@Nashtare Nashtare commented Oct 3, 2024

We are not adding a default new trie mapped to a created address, which can cause errors in parsing if trying to write to storage of a newly created account.

Fixes a bunch of missing storage trie for address FOO on the test chain (I'm not including new payloads on the test cases folder because I am still trying to debug follow-up issues with some of these blocks on the prover side, but I can share payloads, the consistent-with-header integration test passes now).

@Nashtare Nashtare self-assigned this Oct 3, 2024
@github-actions github-actions bot added the crate: trace_decoder Anything related to the trace_decoder crate. label Oct 3, 2024
@Nashtare
Copy link
Collaborator Author

Nashtare commented Oct 3, 2024

The Validate PR job is failing because it crashed parsing, as I had forgotten the closing "" in "the consistent-with-header". Changing the PR description and re-running the job doesn't work, it cached the initial version. Guess we can just ignore it for this PR.

@Nashtare Nashtare merged commit 69e82c0 into develop Oct 3, 2024
19 of 20 checks passed
@Nashtare Nashtare deleted the fix/missing_storage branch October 3, 2024 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
crate: trace_decoder Anything related to the trace_decoder crate.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants