fix: check for gas limit overflow #711
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nashtare
requested review from
0xaatif,
muursh,
wborgeaud and
LindaGuiga
as code owners
github-actions
bot
added
crate: trace_decoder
0xaatif
approved these changes
Oct 8, 2024
muursh
approved these changes
Oct 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When initiating a child context for CALL-like ops, we do not check if the gas limit is smaller than the parent context's, and more specifically we don't even check if the value specified fits in a
u32(our assumption for gas-costs), which yields anIntegerTooLargeerror triggered when exiting the kernel.This is testable with txn 44 of block 2841 (the last
STATICCALLhas agasarg of0xffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff67), added as regression test.5.5/N @praetoriansentry