feat: trait World for trace_decoder
#732
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ckage trace_decoder
github-actions
bot
added
crate: trace_decoder
|
Looked at PR. LGTM |
atanmarko
approved these changes
Oct 21, 2024
| fn collect_tries( | ||
| &mut self, | ||
| _block: U256, | ||
| _batch: usize, | ||
| _state_trie: &StateTrieT, | ||
| _storage: &BTreeMap<H256, StorageTrie>, | ||
| _state_trie: &WorldT, |
There was a problem hiding this comment.
Suggested change
| _state_trie: &WorldT, | |
| _world: &WorldT, |
| } | ||
| } | ||
|
|
||
| impl World for Type2World { |
There was a problem hiding this comment.
Nit: I find it a bit weird to have this before struct Type2World is defined.
muursh
approved these changes
Oct 22, 2024
This was referenced Oct 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #707
Follows #693
Obsoletes #722
Changes
Type2Worldis ready for testing.TypedMpt, and just fold it intoStateMpt.conv_hashmodule.