This repository has been archived by the owner on Jul 9, 2021. It is now read-only.
update ethereumjs-blockstream 6.0.0 -> ^7.0.0 #2089
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
dekz
suggested changes
Aug 22, 2019
| @@ -171,8 +171,8 @@ export class SubscriptionManager<ContractEventArgs, ContractEvents extends strin | |||
| if (this._blockAndLogStreamerIfExists === undefined) { | |||
| throw new Error(SubscriptionErrors.SubscriptionNotFound); | |||
| } | |||
| this._blockAndLogStreamerIfExists.unsubscribeFromOnLogAdded(this._onLogAddedSubscriptionToken as string); | |||
| this._blockAndLogStreamerIfExists.unsubscribeFromOnLogRemoved(this._onLogRemovedSubscriptionToken as string); | |||
| this._blockAndLogStreamerIfExists.unsubscribeFromOnLogsAdded(this._onLogAddedSubscriptionToken as string); | |||
There was a problem hiding this comment.
Looks like 7.0.0 now calls back with an Array of logs rather than calling back with a single log. This type casting should result in a test failure.
There was a problem hiding this comment.
nice catch @dekz . Looks like subscribeToOnLogsAdded/Removed still returns a string, so the subscriptionTokens are still strings. But the callbacks take an array of logs instead of a single log. I think I fixed it in ec2ca78
Thanks for calling my attention to this, wouldn't have noticed it otherwise :/
xianny
force-pushed
the
fix/update-ethereumjs-blockstream
branch
from
ec2ca78 to
d987fec
Compare
dekz
approved these changes
Aug 22, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updates ethereumjs-blockstream.
6.0.0will be removed after we update coordinator-server deps in 0xProject/0x-coordinator-server#14Relates to #1989
Testing instructions
Types of changes
Checklist:
[WIP]if necessary.