Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V3 Doc updates #20

Draft
wants to merge 2 commits into
base: 3.0
Choose a base branch
from
Draft

V3 Doc updates #20

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b0aa6db
fix typo
dekz Sep 17, 2019
1b9a783
Update v3-specification.md
dekz Sep 17, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions v3/v3-specification.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2386,7 +2386,7 @@ For more information about how this is used, see [hashing an order](#hashing-an-

## EIP-1271 Usage

Both the [`Validator](#validator) and [`EIP1271Wallet`](#eip1271wallet) signature types are [EIP-1271](https://github.com/ethereum/EIPs/blob/master/EIPS/eip-1271.md) compliant. Note that this standard does not specify how data should be encoded when it is passed to the verifying contract's `isValidSignature` function. The `Exchange` contract will pass data to the verifying contract that is ABI encoded with one of the following function signatures, depending on if a `Order` or `ZeroExTransaction` is being validated:
Both the [`Validator`](#validator) and [`EIP1271Wallet`](#eip1271wallet) signature types are [EIP-1271](https://github.com/ethereum/EIPs/blob/master/EIPS/eip-1271.md) compliant. Note that this standard does not specify how data should be encoded when it is passed to the verifying contract's `isValidSignature` function. The `Exchange` contract will pass data to the verifying contract that is ABI encoded with one of the following function signatures, depending on if a `Order` or `ZeroExTransaction` is being validated:

```solidity
contract IEIP1271Data {
Expand Down Expand Up @@ -2454,7 +2454,7 @@ Doing any sort of division in the EVM may result in rounding errors. [`fillOrder
- `marketBuyOrders` and `marketSellOrders` have been deprecated
- The addition of [`marketBuyOrdersFillOrKill`](#marketbuyordersfillorkill) and [`marketSellOrdersFillOrKill`](#marketsellordersfillorkill)
- All of the `marketBuy*` and `marketSell*` functions now allow multiple different assets to be bought or sold (be careful with this!)
- The ordering of transfers during a single fill has changed. A fill now first transfers an asset from the taker to the maker, opening up the ability to integrate the [`ERC20BuyerAsseyProxy`](https://github.com/0xProject/ZEIPs/issues/47) (along with other similar contracts)
- The ordering of transfers during a single fill has changed. A fill now first transfers an asset from the taker to the maker, opening up the ability to integrate the [`ERC20BuyerAssetProxy`](https://github.com/0xProject/ZEIPs/issues/47) (along with other similar contracts)

### Changes to order matching

Expand Down