-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce global RPC class storage #499
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marioiordanov
requested changes
Jun 21, 2024
mikiw
suggested changes
Jun 24, 2024
mikiw
suggested changes
Jun 27, 2024
mikiw
approved these changes
Jun 28, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would link it with #272
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Usage related changes
Benchmarking
./scripts/benchmark/command_stat_test.py
(500 mints):main
and Devnet on this PR's branchcargo build --release
With
--state-archive-capacity full
With no feature flags
Conclusion
Development related changes
StarknetState
rpc_contract_classes: Arc<RwLock<CommittedClassStorage>>
crates/starknet-devnet-core/src/starknet/get_class_impls.rs
parking_lot
std
's ortokio
'sblocks_on_demand_declarations
fails onmain
StateDiff
increate_block
.pending_state_diff
by relying on the newly addedStateDiff::extend
.commit_with_diff
renamed tocommit_diff
, no longer accepts thestate_diff
parameter.default_global_contract_cache
.StateDiff::generate
accepts newly declared classes instead of the whole class storage.assert_cairo1_classes_equal
now working with references - removes unnecessary cloning.Checklist:
./scripts/format.sh
./scripts/clippy_check.sh
./scripts/check_unused_deps.sh
./scripts/check_spelling.sh
./website/README.md