Fix Could not get the lock for ID, when creating a site (matomo-org#1…

…5401) * Lock key start * do not empty key lock Co-authored-by: Thomas Steur <[email protected]>
1024pix · Sep 22, 2020 · 1deb64b · 1deb64b
1 parent d558b36
commit 1deb64b
Showing 1 changed file with 6 additions and 2 deletions.
diff --git a/core/Concurrency/Lock.php b/core/Concurrency/Lock.php
@@ -50,11 +50,15 @@ public function getAllAcquiredLockKeys()
 
     public function execute($id, $callback)
     {
-        if (Common::mb_strlen($id) > self::MAX_KEY_LEN) {
+        $maxLen = self::MAX_KEY_LEN;
+        if (!empty($this->lockKeyStart)) {
+            $maxLen = $maxLen - strlen($this->lockKeyStart);
+        }
+        if (Common::mb_strlen($id) > $maxLen) {
             // Lock key might be too long for DB column, so we hash it but leave the start of the original as well
             // to make it more readable
             $md5Len = 32;
-            $id = Common::mb_substr($id, 0, self::MAX_KEY_LEN - $md5Len - 1) . md5($id);
+            $id = Common::mb_substr($id, 0, $maxLen - $md5Len - 1) . md5($id);
         }
 
         $i = 0;