[BUGFIX] Ordonner les skillName afin de garantir l'ordre des colonnes lors de l'export de résultat (Pix-16196) #11220
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xav-car
added
👀 Tech Review Needed
👀 Func Review Needed
team-prescription
⚠️ PR Inheritance
xav-car
changed the base branch from
dev
to
pix-16195/campaign-learning-content-refacto
|
Question : sur cette PR, dans les profils cibles, on a des sujets triés par thématiques, et dans le fichier d'export, les sujets n'apparaissent pas dans le même ordre, ils sont triés par ordre alphabétique à l'intérieur de la compétence. |
|
Func OK, tech OK 🦦 🐼 |
| @@ -15,6 +15,10 @@ class CampaignLearningContent extends LearningContent { | |||
| return super.competences.sort((a, b) => a.index.localeCompare(b.index)); | |||
| } | |||
|
|
|||
| get skills() { | |||
| return this.competences.flatMap((competence) => competence.skills.sort((a, b) => a.name.localeCompare(b.name))); | |||
| } | |||
There was a problem hiding this comment.
Question: pourquoi ne pas faire un super.skills ?
alicegoarnisson
added
Func Review OK
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🥞 Problème
certains export comporte les nom des acquis pour des traitement plus "fin" . le souci c'est que nous ne garantissons pas l'ordre entre différent export
🥓 Proposition
Trier ces noms d'acquis par rapport à sa compétence, puis par son nom.
🧃 Remarques
RAS
😋 Pour tester
CI au vert,
Allez sur PixAdmin :
Allez sur PixOrga :