Fix include viewStyle assets in dynamic version generation
#436
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: b7da8ff The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
fabiankaegy
force-pushed
the
fix/also-bust-cache-for-view-style
branch
from
7a2651a to
4321d3b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
WordPress uses the
versionproperty of ablock.jsonfile as the cache busting property for any style assets that are defined in it. This is okay but means you have to manually update a version parameter every time. If you don't it will use the current WordPress version as a fallback.In #281 we added some handling to toolkit which automatically generates and injects a version param if there isn't already one defined that consists of a hash of all the assets starting with
file:.This automatically generated
versioncurrently only accounts forstyleassets.viewStyleassets are not handled and therefore don't trigger the version generation.This fixes that by also handling
viewStylein the same way.Props to @smwoll for raising this to me 🚀