fix/170v2: add filter to delay post saving. #173
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sidsector9
requested review from
jeffpaul,
dkotter and
dsawardekar
as code owners
4 tasks
dsawardekar
requested changes
Jul 1, 2024
| wp_localize_script( | ||
| 'convert_to_blocks_editor', | ||
| 'convert_to_blocks_agent', | ||
| [ | ||
| 'agent' => [ | ||
| 'next' => $this->next(), | ||
| 'next' => $this->next(), | ||
| 'save_delay' => apply_filters( 'convert_to_blocks_save_delay', 500, $post_id ) |
There was a problem hiding this comment.
@Sidsector9 Lets change this to 0, or there is no delay to match the legacy behaviour. For context, 500 ms adds hours to a migration that has 100k posts.
assets/js/editor/editor.js
Outdated
| client.save(); | ||
| setTimeout(() => { | ||
| client.save(); | ||
| }, config.agent.save_delay); |
There was a problem hiding this comment.
@Sidsector9 Lets add a JS fallback to 0 in case the BE doesn't send this var. Sometimes this happens on large migrations when the BE stalls. If save_delay is 0, then call save directly instead of using the setTimeout.
dsawardekar
approved these changes
Jul 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
Closes #170
How to test the Change
heading. (Just to test if the PR works as expected to transform other elements to blocks).wp convert-to-blocks start --post_type=postChangelog Entry
Credits
Props @mdesplenter, @Sidsector9 @dsawardekar
Checklist: