Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH action summary added for e2e test #119

Merged
merged 3 commits into from
Jun 30, 2023
Merged

GH action summary added for e2e test #119

merged 3 commits into from
Jun 30, 2023

Conversation

jayedul
Copy link
Contributor

@jayedul jayedul commented Jun 21, 2023

Description of the Change

GH action summary added Cypress test report

Closes #106

Changelog Entry

Added - GH action summary added Cypress test report

Credits

Props @jayedul

Checklist:

  • I agree to follow this project's Code of Conduct.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests pass.

@jayedul jayedul self-assigned this Jun 21, 2023
@jayedul
Copy link
Contributor Author

jayedul commented Jun 21, 2023

This PR has been marked as ready for review though one action is failing which is unrelated tho this PR in fact.

@jayedul jayedul marked this pull request as ready for review June 21, 2023 17:16
@jayedul jayedul requested review from jeffpaul and a team as code owners June 21, 2023 17:16
@jeffpaul jeffpaul removed their request for review June 21, 2023 17:18
@jeffpaul jeffpaul added this to the 1.3.0 milestone Jun 21, 2023
@jeffpaul jeffpaul requested review from a team, faisal-alvi and ravinderk and removed request for a team and faisal-alvi June 21, 2023 17:18
tests/cypress/config.js Outdated Show resolved Hide resolved
Copy link

@ravinderk ravinderk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jayedul I left a suggestion.

Questions:
Did you run this workflow on the fork to test? Can you provide a link?

@jayedul
Copy link
Contributor Author

jayedul commented Jun 30, 2023

@ravinderk I've run it locally. And it is generating the report as expected. No shareable link for now as it is not deployed anywhere else.
Screenshot 2023-06-30 at 12 30 39 PM

@jayedul jayedul requested a review from ravinderk June 30, 2023 06:38
@jeffpaul jeffpaul merged commit 4926ebd into develop Jun 30, 2023
@jeffpaul jeffpaul deleted the update/106 branch June 30, 2023 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a GH Actions summary
3 participants