Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/121 PHP Version Check #132

Merged
merged 18 commits into from
Sep 19, 2023
Merged

Fix/121 PHP Version Check #132

merged 18 commits into from
Sep 19, 2023

Conversation

bmarshall511
Copy link
Contributor

Description of the Change

Added a minimum PHP version check for 7.4.

Closes #121

How to test the Change

  1. Spin up the site with a version of PHP below 7.4
  2. Verify an admin notice has been added alerting the user of the failed check
  3. Verify the admin nav doesn't include any of the custom post type options or settings

Changelog Entry

Added - >=PHP 7.4 version check

Credits

Props @bmarshall511

Checklist:

  • I agree to follow this project's Code of Conduct.
  • I have updated the documentation accordingly.

helen and others added 15 commits July 29, 2019 20:40
@bmarshall511 bmarshall511 added the needs:code-review This requires code review. label Sep 15, 2023
@bmarshall511 bmarshall511 requested a review from a team as a code owner September 15, 2023 13:51
@bmarshall511 bmarshall511 self-assigned this Sep 15, 2023
@bmarshall511 bmarshall511 requested review from iamdharmesh and removed request for a team September 15, 2023 13:51
iamdharmesh
iamdharmesh requested changes Sep 18, 2023
View reviewed changes
Copy link
Member

@iamdharmesh iamdharmesh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @bmarshall511. Added a minor note to discuss.

Thank you.

eight-day-week.php Outdated Show resolved Hide resolved
@jeffpaul jeffpaul added this to the 1.2.3 milestone Sep 18, 2023
iamdharmesh
iamdharmesh previously approved these changes Sep 19, 2023
View reviewed changes
Copy link
Member

@iamdharmesh iamdharmesh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes @bmarshall511. LGTM!

@dkotter it seems the PR branch checked out from the trunk branch, so it shows some commits of the trunk branch in diff. Do you see any disadvantages of merging this to develop a branch?

@dkotter dkotter modified the milestones: 1.2.3, 1.3.0 Sep 19, 2023
@dkotter dkotter merged commit 4acf9db into develop Sep 19, 2023
@dkotter dkotter deleted the fix/121-php-version-check branch September 19, 2023 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dkotter dkotter dkotter approved these changes

@iamdharmesh iamdharmesh iamdharmesh left review comments

Assignees

@bmarshall511 bmarshall511

Labels
needs:code-review This requires code review.
Projects
None yet
Milestone
1.2.3
Development

Successfully merging this pull request may close these issues.

Add PHP checks
7 participants
@bmarshall511 @dkotter @iamdharmesh @jeffpaul @helen @peterwilsoncc @Sidsector9