Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add plugin images for .ORG #30

Merged
merged 3 commits into from
Jul 29, 2019
Merged

Add plugin images for .ORG #30

merged 3 commits into from
Jul 29, 2019

Conversation

jeffpaul
Copy link
Member

Description of the Change

Adds the various banner and icon files needed for WordPress.org repo display.

Alternate Designs

none.

Benefits

Provides design above the generic null design from .org.

Possible Drawbacks

none identified.

Verification Process

Manually verified via GitHub Desktop native folder UI.

Checklist:

  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests passed.

Applicable Issues

Resolves #18.

@jeffpaul jeffpaul added the needs:documentation This requires documentation. label Jul 25, 2019
@jeffpaul jeffpaul added this to the 1.1.0 milestone Jul 25, 2019
@jeffpaul jeffpaul requested a review from adamsilverstein July 25, 2019 16:57
@jeffpaul jeffpaul self-assigned this Jul 25, 2019
@jeffpaul
Copy link
Member Author

Changelog entry:

### Added
- plugin banner and icon images (props @chriswallace via #30)

adamsilverstein
adamsilverstein approved these changes Jul 26, 2019
View reviewed changes
Copy link

@adamsilverstein adamsilverstein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

@helen helen merged commit 3ecc196 into develop Jul 29, 2019
@jeffpaul jeffpaul deleted the add/design-assets branch September 30, 2020 01:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamsilverstein adamsilverstein adamsilverstein approved these changes

Assignees

@jeffpaul jeffpaul

Labels
needs:documentation This requires documentation.
Projects
None yet
Milestone
1.1.0
Development

Successfully merging this pull request may close these issues.

Design for plugin logo, banner
3 participants
@jeffpaul @adamsilverstein @helen