Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: cant change role using upper print role dropdown #58

Merged
merged 1 commit into from
Jul 17, 2020
Merged

Conversation

dinhtungdu
Copy link
Contributor

@dinhtungdu dinhtungdu commented Jun 24, 2020

Description of the Change

Fixes #57

Use different name allows user to use both upper and lower print role dropdown.

Alternate Designs

N/A.

Benefits

See above.

Possible Drawbacks

None identified.

Verification Process

  1. Go to Users.
  2. Select some users who have print role set.
  3. Choose a role from the upper print role dropdown.
  4. Click Change.
  5. See the user's role is updated correctly.
  6. Repeat the steps above but with the lower print role dropdown and see the same result.

Checklist:

  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests passed.

@dinhtungdu dinhtungdu changed the title fix: cant change role using upper print role dropdown Fix: cant change role using upper print role dropdown Jun 24, 2020
@dinhtungdu dinhtungdu self-assigned this Jun 24, 2020
@dinhtungdu dinhtungdu requested a review from jeffpaul June 24, 2020 10:01
@jeffpaul jeffpaul added this to the 1.2.0 milestone Jun 24, 2020
@jeffpaul jeffpaul requested a review from dkotter June 24, 2020 13:43
@jeffpaul jeffpaul modified the milestones: 1.2.0, 1.1.2 Jul 14, 2020
@jeffpaul jeffpaul merged commit eef098e into develop Jul 17, 2020
@jeffpaul jeffpaul deleted the fix/57 branch September 30, 2020 01:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't change print role in the User list screen
3 participants