Added "Build release zip" GitHub Action #168
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
faisal-alvi
requested review from
a team and
peterwilsoncc
and removed request for
a team
peterwilsoncc
requested changes
Dec 4, 2022
There was a problem hiding this comment.
I reviewed the zip file generated on your repo in the action https://github.com/faisal-alvi/simple-local-avatars/actions/runs/3603276090
As noted inline, it's including some files that aren't needed.
Comment on lines
17
to
27
| - name: Cache vendor | ||
| id: cache-composer | ||
| uses: actions/cache@v3 | ||
| env: | ||
| cache-name: cache-vendor | ||
| with: | ||
| path: | | ||
| vendor | ||
| ~/.composer/cache | ||
| key: ${{ runner.os }}-build-${{ env.cache-name }}-${{ hashFiles('**/composer.json') }} | ||
|
|
There was a problem hiding this comment.
Composer only uses dev dependencies and isn't loaded in production (ie, autoload isn't referenced) so can be ignored from the build here. It's not included in the wp.org version either, see https://plugins.trac.wordpress.org/browser/simple-local-avatars/trunk
There was a problem hiding this comment.
The composer dependencies install step is removed.
peterwilsoncc
approved these changes
Dec 5, 2022
|
@peterwilsoncc I checked the new zip and it now matches with the wp.org ( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
PR Adds "Build release zip" GitHub Action to generate the release zip before the actual release and Release Instructions are updated to test generated zip before shipping a release.
Closes #167
How to test the Change
Fork the repo, merged this workflow, and tested the ZIP locally.
Changelog Entry
Added - "Build release zip" GitHub Action.
Credits
Props @faisal-alvi
Checklist: