Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PLUGIN_VERSION is too generic #78

Closed
1 task done
dinhtungdu opened this issue Feb 25, 2022 · 1 comment · Fixed by #81
Closed
1 task done

PLUGIN_VERSION is too generic #78

dinhtungdu opened this issue Feb 25, 2022 · 1 comment · Fixed by #81
Labels
type:enhancement New feature or request. type:good-first-issue Good for newcomers.
Milestone
2.4.0

Comments

@dinhtungdu
Copy link
Contributor

Is your enhancement related to a problem? Please describe.

In #74, we introduced a new constant named PLUGIN_VERSION. IMO that constant is too generic and has a higher chance to be conflicted with other plugins/themes. I think we should change it to one that is specific to Simple Page Ordering.

Designs

No response

Describe alternatives you've considered

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct
@dinhtungdu dinhtungdu added type:enhancement New feature or request. type:good-first-issue Good for newcomers. labels Feb 25, 2022
@jeffpaul
Copy link
Member

Totally agree, nice catch. SIMPLE_PAGE_ORDERING_VERSION might be better.

@jeffpaul jeffpaul added this to the 2.4.0 milestone Feb 25, 2022
@jeffpaul jeffpaul moved this to Incoming in Open Source Practice Feb 25, 2022
@jeffpaul jeffpaul moved this from Incoming to To Do in Open Source Practice Feb 25, 2022
@dinhtungdu dinhtungdu mentioned this issue Feb 25, 2022
Merged
6 tasks
Repository owner moved this from To Do to Merged in Open Source Practice Feb 25, 2022
@vikrampm1 vikrampm1 moved this from Merged to Done/Released in Open Source Practice Jun 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type:enhancement New feature or request. type:good-first-issue Good for newcomers.
Projects
Open Source Practice
Archived in project
Milestone
2.4.0
Development

Successfully merging a pull request may close this issue.

Rename PLUGIN_VERSION to SIMPLE_PAGE_ORDERING_VERSION 10up/simple-page-ordering
2 participants
@jeffpaul @dinhtungdu