Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename PLUGIN_VERSION to SIMPLE_PAGE_ORDERING_VERSION #81

Merged
merged 1 commit into from
Feb 25, 2022
Merged

Rename PLUGIN_VERSION to SIMPLE_PAGE_ORDERING_VERSION #81

merged 1 commit into from
Feb 25, 2022

Conversation

dinhtungdu
Copy link
Contributor

@dinhtungdu dinhtungdu commented Feb 25, 2022 •
edited
Loading

Description of the Change

As the title says.

Closes #78.

Alternate Designs

N/a

Possible Drawbacks

N/a

Verification Process

Manual verification, ensure no warning/error is thrown.

Checklist:

  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests passed.

Changelog Entry

Credits

Props @dinhtungdu

@dinhtungdu dinhtungdu requested review from a team and Sidsector9 and removed request for a team February 25, 2022 02:18
@dinhtungdu dinhtungdu added the type:enhancement New feature or request. label Feb 25, 2022
@dinhtungdu dinhtungdu self-assigned this Feb 25, 2022
@dkotter dkotter merged commit ca7499e into develop Feb 25, 2022
@dkotter dkotter deleted the fix/78 branch February 25, 2022 17:58
@jeffpaul jeffpaul added this to the 2.4.0 milestone Mar 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dkotter dkotter dkotter approved these changes

@Sidsector9 Sidsector9 Awaiting requested review from Sidsector9 Sidsector9 was automatically assigned from 10up/open-source-practice

Assignees

@dinhtungdu dinhtungdu

Labels
type:enhancement New feature or request.
Projects
Open Source Practice
Archived in project
Milestone
2.4.0
Development

Successfully merging this pull request may close these issues.

PLUGIN_VERSION is too generic
3 participants
@dinhtungdu @dkotter @jeffpaul