Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable Post Revisions using the correct action #26

Merged
merged 1 commit into from
Oct 8, 2019

Conversation

jakejackson1
Copy link
Contributor

@jakejackson1 jakejackson1 commented Sep 12, 2018

WordPress adds wp_save_post_revision to the post_updated action and not pre_post_update, as can be seen here: https://github.com/WordPress/WordPress/blob/56c162fbc9867f923862f64f1b4570d885f1ff03/wp-includes/default-filters.php#L342

WordPress adds this filter onto 'post_updated' and not 'pre_post_update', as can be seen here: https://github.com/WordPress/WordPress/blob/56c162fbc9867f923862f64f1b4570d885f1ff03/wp-includes/default-filters.php#L342

This will reduce overhead, but will also prevent a conflict with JetPack's Markdown module which sees the markdown converted back to HTML.
@pattonwebz
Copy link
Contributor

This PR looks ok, I will try to test the code change today if I can.

@jeffpaul jeffpaul added this to the 2.4.0 milestone May 2, 2019
Copy link

@adamsilverstein adamsilverstein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch, thank you @jakejackson1!

@adamsilverstein adamsilverstein merged commit 98bf7aa into 10up:develop Oct 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants