Upgrade grunt to 10up-toolkit

[cadic]

Description of the Change

This PR changes the build tool from grunt to https://github.com/10up/10up-toolkit

• The resulting scripts path changed to dist (added to .gitignore)
• Added new scripts npm run build, npm run dev and npm run makepot
• Updated enqueue functions in the main PHP plugin file.
• Removed old compiled assets from git
• Updated cypress and push-deploy workflows to include the build step

Closes #79

Possible Drawbacks

1

Keep attention to the push-deploy GitHub Actions workflow. Before this change, compiled assets were hold in the repository and was ready to deploy without any additional steps. After this change, a build step is required.

2

Before this change, the SCRIPT_DEBUG php constant was used to force enqueueing the source JS. After this change, the npm run dev command starts the watch process, saves the debugging version of the JS and CSS files with sourcemaps. No additional setup needed for assets debugging.

Verification Process

1. Clone the repo
2. Run npm install
3. Perform npm run build
4. Expected to have assets in dist and pot file in localization
5. Expected all plugin features to work

The push-deploy workflow was tested with a set of commands:

• npm install
• npm run build
• rsync -rc --exclude-from=".distignore" . trunk/ --delete --delete-excluded

The resulting trunk folder contain the correct list of files.

Checklist:

• I have read the CONTRIBUTING document.
• My code follows the code style of this project.
• My change requires a change to the documentation.
• I have updated the documentation accordingly.
• I have added tests to cover my change.
• All new and existing tests passed.

Changelog Entry

Changed - Replaced Grunt with 10up-toolkit

Credits

Props @cadic

[cadic]

Converting to draft as it needs improvement in push-deploy GitHub Action: change .gitattributes to .distignore workflow

[cadic]

The deploy process was tested with command:

rsync -rc --exclude-from=".distignore" . trunk/ --delete --delete-excluded

@peterwilsoncc this is ready to review now

[jeffpaul]

@cadic looks like a merge conflict that needs to be resolved. @peterwilsoncc pinging you for reminder on code review here... thanks!

[peterwilsoncc]

I've added a few notes, the code looks good so it's mainly defensive development to protect ourselves against future errors.

Are you able to resolve the merge conflicts while making any changes?

[peterwilsoncc]

My understanding of the 10up WP.org deploy actions is that it observes export-ignore from the git attributes file if it is set. Is this needed too?

This is absolutely a question rather than a passive aggressive change request!! I'm still learning about the deploy actions.

[peterwilsoncc]

✅ Plugin repo guideline four (readable code) met by inclusion of the link to the GitHub repo.

[jeffpaul]

@cadic some feedback for you here, if you're not able to get to this please ping the OSP for someone else to pick this up and help finish it off... thanks!

[peterwilsoncc]

Looks good to me, thank you!

Manual testing passed.