Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add build pre-release zip action #199

Merged
merged 6 commits into from
Dec 1, 2022
Merged

add build pre-release zip action #199

merged 6 commits into from
Dec 1, 2022

Conversation

Sidsector9
Copy link
Member

@Sidsector9 Sidsector9 commented Nov 24, 2022 •
edited
Loading

Description of the Change

  • Adds a workflow to generate a pre-release ZIP artifact.
  • Update Release Instructions.

Verification Process

  • Forked the repo, merged this workflow and tested the ZIP locally.

Checklist:

  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests passed.

Changelog Entry

Props @Sidsector9

@Sidsector9 Sidsector9 self-assigned this Nov 24, 2022
iamdharmesh
iamdharmesh reviewed Nov 30, 2022
View reviewed changes
Copy link
Member

@iamdharmesh iamdharmesh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for the PR @Sidsector9, approach taken here looks good to me. Just added one minor note here.

.github/workflows/build-release-zip.yml Outdated Show resolved Hide resolved
@jeffpaul jeffpaul requested a review from iamdharmesh November 30, 2022 17:59
@jeffpaul jeffpaul added this to the 1.4.0 milestone Dec 1, 2022
@dkotter dkotter merged commit 5b0f237 into develop Dec 1, 2022
@dkotter dkotter deleted the upkeep/add-pre-release-zip branch December 1, 2022 21:09
This was referenced Dec 2, 2022
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
@Sidsector9 Sidsector9 mentioned this pull request Dec 11, 2022
Closed
1 task
This was referenced Dec 22, 2022
Closed
Closed
Closed
Open
@vikrampm1 vikrampm1 mentioned this pull request Dec 22, 2022
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dkotter dkotter dkotter approved these changes

@jeffpaul jeffpaul Awaiting requested review from jeffpaul jeffpaul is a code owner

@cadic cadic Awaiting requested review from cadic

@iamdharmesh iamdharmesh Awaiting requested review from iamdharmesh

Assignees

@Sidsector9 Sidsector9

Labels
None yet
Projects
None yet
Milestone
1.4.0
Development

Successfully merging this pull request may close these issues.
4 participants
@Sidsector9 @dkotter @iamdharmesh @jeffpaul