Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/issue 83 latest episode block #266

Merged
merged 7 commits into from
Jan 18, 2024

Conversation

barneyjeffries
Copy link
Contributor

Description of the Change

Added variation based on Query Loop for Latest Episode

Closes #83

Alternate Designs

Possible Drawbacks

Verification Process

Checklist:

  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests passed.

Changelog Entry

Credits

Props @

@barneyjeffries barneyjeffries requested a review from a team as a code owner January 3, 2024 13:09
@barneyjeffries barneyjeffries requested review from faisal-alvi and removed request for a team January 3, 2024 13:09
@github-actions github-actions bot added this to the 1.7.0 milestone Jan 3, 2024
@github-actions github-actions bot added the needs:feedback This requires feedback to determine next steps. label Jan 3, 2024
Copy link
Contributor

github-actions bot commented Jan 3, 2024

@barneyjeffries thanks for the PR! Could you please fill out the PR template with description, changelog, and credits information so that we can properly review and merge this?

@faisal-alvi
Copy link
Member

@barneyjeffries thanks for the PR, can you please check the PHPCS issues and fix it?

https://github.com/10up/simple-podcasting/actions/runs/7397681115/job/20125248325

Copy link
Member

@faisal-alvi faisal-alvi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will continue the review after the PHPCS issues are addressed, thanks!

@barneyjeffries
Copy link
Contributor Author

@faisal-alvi yes of course - sorry meant to check these before

@github-actions github-actions bot removed the needs:feedback This requires feedback to determine next steps. label Jan 8, 2024
@github-actions github-actions bot added the needs:feedback This requires feedback to determine next steps. label Jan 10, 2024
@dkotter dkotter modified the milestones: 1.7.0, 1.8.0 Jan 11, 2024
@jeffpaul jeffpaul requested a review from faisal-alvi January 12, 2024 15:51
@faisal-alvi
Copy link
Member

faisal-alvi commented Jan 15, 2024

@barneyjeffries thanks for the fixes, the cypress test if failing for the WP minimum. I tried re-running the test but it failed again. Can you please check?

https://github.com/10up/simple-podcasting/actions/runs/7477805060/job/20488930685

Copy link
Member

@faisal-alvi faisal-alvi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

waiting until cypress tests pass

@barneyjeffries
Copy link
Contributor Author

@faisal-alvi @jeffpaul I think we should pause on CR for this PR as I'm working on the Player enhancements which will supersede this change.

@github-actions github-actions bot removed the needs:feedback This requires feedback to determine next steps. label Jan 16, 2024
@barneyjeffries
Copy link
Contributor Author

@faisal-alvi @jeffpaul Apologies, I got confused with the 'Listen Time' task - this task is not related to the Player Enhancements.

I will into the tests and why they are failing.

@barneyjeffries
Copy link
Contributor Author

@faisal-alvi @jeffpaul I've run the tests locally and the block test is working correctly - I have had this before with Cypress, but I don't think anything in this PR should have affected these existing tests.

@jeffpaul jeffpaul requested a review from faisal-alvi January 17, 2024 21:43
Copy link
Member

@faisal-alvi faisal-alvi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for working on this.

BE:

image

FE:

image

@jeffpaul jeffpaul merged commit daa8703 into develop Jan 18, 2024
@jeffpaul jeffpaul deleted the feature/issue-83-latest-episode-block branch January 18, 2024 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Block Pattern: Latest Episode Block
4 participants