Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upkeep/wp-deploy: Move from actions/upload-release-asset to softprops/action-gh-release #308

Merged
merged 3 commits into from
Aug 12, 2024

Conversation

Sidsector9
Copy link
Member

@Sidsector9 Sidsector9 commented Jul 19, 2024

Description of the Change

actions/upload-release-asset has been deprecated and softprops/action-gh-release is the recommended replacement.

How to test the Change

Verify the ZIP attached in a release.

Changelog Entry

Changed - Move from actions/upload-release-asset to softprops/action-gh-release Github action.

@Sidsector9 Sidsector9 requested a review from jeffpaul as a code owner July 19, 2024 15:17
@Sidsector9 Sidsector9 self-assigned this Jul 19, 2024
@github-actions github-actions bot added this to the 1.8.1 milestone Jul 19, 2024
@github-actions github-actions bot added the needs:feedback This requires feedback to determine next steps. label Jul 19, 2024
Copy link
Contributor

@Sidsector9 thanks for the PR! Could you please fill out the PR template with description, changelog, and credits information so that we can properly review and merge this?

Copy link
Member

@jeffpaul jeffpaul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

failing e2e tests on latest not linked to this PR change

@jeffpaul jeffpaul merged commit 44f2a5f into develop Aug 12, 2024
10 of 14 checks passed
@jeffpaul jeffpaul deleted the upkeep/wp-deploy branch August 12, 2024 13:28
@dkotter dkotter modified the milestones: 1.8.1, 1.9.0 Nov 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs:feedback This requires feedback to determine next steps.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants