Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Azure Upload Progress Hotfix #109

Closed
wants to merge 3 commits into from
Closed

Conversation

rickalee
Copy link
Collaborator

Add transient for file uploads to track the progress of offloading to Azure when wp_generate_attachment_metadata runs. Ensure PDF generated thumbnails are offloaded with JPEG mime type instead of PDF.

Description of the Change

Alternate Designs

Benefits

Possible Drawbacks

Verification Process

Checklist:

  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests passed.

Applicable Issues

Changelog Entry

…re when wp_generate_attachment_metadata runs. Ensure PDF generated thumbnails are offloaded with JPEG mimetype instead of PDF.
@rickalee rickalee changed the title Azure Upload Progress Hotfix. Azure Upload Progress Hotfix Nov 26, 2019
@jeffpaul jeffpaul added this to the 4.4.0 milestone Nov 26, 2019
@jeffpaul jeffpaul added the type:bug Something isn’t working. label Nov 26, 2019
@jeffpaul
Copy link
Member

jeffpaul commented Dec 2, 2019

@moraleida waiting on your confirmation from testing, please keep us posted, thanks!

@moraleida
Copy link

@jeffpaul @rickalee this was tested on preprod last week. It did indeed reduce the server load when uploading hundreds of images but something doesn't seem correct about the numbers (percentages and totals) reported in the admin. We'll need to test a bit more to make sure we don't break that.

@jeffpaul jeffpaul mentioned this pull request Dec 9, 2019
6 tasks
@rickalee
Copy link
Collaborator Author

rickalee commented Dec 9, 2019

@moraleida I believe you are correct. I will work on fix to add original_image to count if source is larger than 2560.

@jeffpaul jeffpaul modified the milestones: 4.4.0, 4.3.1 Feb 11, 2020
@jeffpaul
Copy link
Member

@rickalee we can close this in favor of #110, correct?

@rickalee
Copy link
Collaborator Author

@jeffpaul Yes. #110 includes these changes.

@rickalee rickalee closed this Feb 11, 2020
@jeffpaul jeffpaul deleted the hotfix/get_azure_progress branch March 3, 2021 02:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:bug Something isn’t working.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants