-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Align PHP minimum version checks #202
Conversation
@10up/open-source-practice could use a quick code review on this for the 4.4.0 release, thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@radeno, I left a few suggestions. LEt me know if you have any questions.
@jeffpaul @ravinderk Should we use https://github.com/10up/wp-compat-validation-tool instead of adding manual checks across all plugins? There is |
@faisal-alvi yes, probably worth updating to that newly available tool |
Fixed PR. It was made by a hot needle in Github web app. Sorry, I called incorrect PHP function. It should be |
@radeno can you use wp-compat-validation-tool library to validate the PHP version? Sample code: https://github.com/10up/maps-block-apple/pull/174/files |
@ravinderk from my point of view this is bigger change. My PR aligned two different PHP versions (7.4 and 8.0) checks currently implemented to just one (8.0). That's all. |
Description of the Change
After merging 3b7f2fa there was introduced helper method. Align PHP version checking
Closes #
How to test the Change
Changelog Entry
Credits
Props @username, @username2, ...
Checklist: