Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHPUnit 6 Compatibility #88

Closed
johnpbloch opened this issue Feb 24, 2017 · 6 comments
Closed

PHPUnit 6 Compatibility #88

johnpbloch opened this issue Feb 24, 2017 · 6 comments
Milestone

Comments

@johnpbloch
Copy link
Contributor

This is related to #84. We will eventually need to support PHPUnit 6. For now, we're just requiring a version >=4.4 and <6.0. Ideally we can support PHPUnit 6.0 and lower, although I'm not sure how, since a lot of the codebase has been restructured (e.g. PHPUnit_Framework_TestCase has been renamed to PHPUnit\Framework\TestCase).

@ChrisWiegman
Copy link

Hi @johnpbloch have y'all made any progress on this?

@ericmann
Copy link
Collaborator

We're working on getting things updated. PHPUnit 6 compat is one of several items on my todo list.

@polevaultweb
Copy link

@ericmann that would be awesome 👍

@moraleida
Copy link

Started to take a look into this and it looks like we'll have to wait for Mockery to extend support first: mockery/mockery#728

As far as I could test, any tests (on this repo) that do not require mockery run fine after changing the extends signatures to the new namespaced format.

@sudar
Copy link
Contributor

sudar commented Dec 3, 2017

Now that mockery/mockery#728 is fixed, I have created a PR (#112) that adds support for phpunit 6.0

If you are already using wp_mocks in a project please test the PR.

@ericmann
Copy link
Collaborator

ericmann commented Dec 3, 2017

Fixed in #112

@ericmann ericmann closed this as completed Dec 3, 2017
@jeffpaul jeffpaul added this to the 0.3.0 milestone Sep 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants