Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fails with PHPUnit 6.0.6 #84

Closed
ChrisWiegman opened this issue Feb 14, 2017 · 3 comments
Closed

Fails with PHPUnit 6.0.6 #84

ChrisWiegman opened this issue Feb 14, 2017 · 3 comments
Milestone

Comments

@ChrisWiegman
Copy link

Using the latest PHPUnit WP_Mock causes a failure with the following error:

PHP Fatal error: Class 'PHPUnit_Framework_TestCase' not found in .../vendor/10up/wp_mock/WP_Mock/Tools/TestCase.php on line 12

@johnpbloch
Copy link
Contributor

It looks like PHPUnit 6.0 changed PHPUnit_Framework_TestCase to PHPUnit\Framework\TestCase. For now, I think we should modify the composer requirements from "phpunit/phpunit": ">=4.3" to "phpunit/phpunit": ">=4.3 <6.0" in the dev branch and "phpunit/phpunit": ">=3.7 <6.0" in master. We can look into how we might accommodate both paradigms later, but for now, let's just make sure composer lets users know about the incompatibility. What do you think @ChrisWiegman ?

@johnpbloch
Copy link
Contributor

The other option would be to specify phpunit >= 6.0 as conflicting with wp mock

@ChrisWiegman
Copy link
Author

Either would handle it for now, at least in preventing issues that is. I'd like to keep this issue open past the version limitation however in an effort to put in place a more permanent fix later.

johnpbloch pushed a commit to johnpbloch/wp_mock that referenced this issue Feb 24, 2017
johnpbloch pushed a commit to johnpbloch/wp_mock that referenced this issue Feb 24, 2017
@bswatson bswatson modified the milestone: 1.0 Feb 24, 2017
@jeffpaul jeffpaul added this to the 0.2.0 milestone Sep 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants