Add PHPCS (+ fixer) and set coding style to PSR12 #181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
unfulvio-godaddy
force-pushed
the
add-phpcs-with-per-coding-standards
branch
from
9733469 to
22ab571
Compare
unfulvio-godaddy
changed the title
rneudorf-godaddy
approved these changes
Dec 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds PHPCS (via PHPCompatibility) and sets the coding style to PSR12.
PHP CS Fixer is also added to format all existing codebase to that standard.
Details
Need to confirm if PSR12 is the desired standard, and the current automatic refactor from PHP CS Fixer is acceptable. The plan would be to iterate on the code while updating/adding tests and addressing both code style and PhpStan code level as we go.
QA