-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Hook::safe_offset() to handle closures #183
Merged
agibson-godaddy
merged 13 commits into
trunk
from
feature/support-closures-anonymous-functions
Jan 3, 2023
Merged
Update Hook::safe_offset() to handle closures #183
agibson-godaddy
merged 13 commits into
trunk
from
feature/support-closures-anonymous-functions
Jan 3, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agibson-godaddy
approved these changes
Jan 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Reimplements #174 after implementing PhpStan and code styles in WP_Mock. Tests have been reworked in PhpUnit.
Quote from OP:
Closes: #89
Test
Open questions
I think we could rename
safe_offset()
into something more meaningful to make it easier to understand what it does. Seems this is used solely within theHook
abstract and Filter/Action implementations to get a string representations of the hook arguments. We could rename it using camel case and soft deprecate the former method.As predicted, PhpStan will start spitting errors as tests, return types and such start to change. I covered some of the issues in this PR, but had to update the baseline to fix several unrelated positives which we can address in subsequent PRs.