Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove WP_Mock/Loader #196

Merged
merged 2 commits into from
Jan 3, 2023
Merged

Remove WP_Mock/Loader #196

merged 2 commits into from
Jan 3, 2023

Conversation

unfulvio-godaddy
Copy link
Member

@unfulvio-godaddy unfulvio-godaddy commented Jan 3, 2023 •
edited by agibson-godaddy
Loading

Summary

Removes WP_Mock\Loader.

Closes: #195

Details

I do not see any occurrences where the class is currently used.

Contributor checklist

  • I agree to follow this project's Code of Conduct.
  • I have updated the documentation accordingly
  • I have added tests to cover changes introduced by this pull request
  • All new and existing tests pass

Testing

Reviewer checklist

  • Code changes review
  • Documentation changes review
  • Unit tests pass
  • Static analysis passes

@unfulvio-godaddy unfulvio-godaddy self-assigned this Jan 3, 2023
@unfulvio-godaddy unfulvio-godaddy requested a review from a team January 3, 2023 09:01
@coveralls
Copy link

coveralls commented Jan 3, 2023 •
edited
Loading

Coverage Status

Coverage: 14.743% (+0.2%) from 14.501% when pulling c8f49eb on issue/195-remove-wp-mock-loader into c8dd29d on trunk.

@agibson-godaddy agibson-godaddy merged commit 9d16132 into trunk Jan 3, 2023
@agibson-godaddy agibson-godaddy deleted the issue/195-remove-wp-mock-loader branch January 3, 2023 10:35
@jeffpaul jeffpaul added this to the 0.6.0 milestone Jan 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@agibson-godaddy agibson-godaddy agibson-godaddy approved these changes

Assignees

@unfulvio-godaddy unfulvio-godaddy

Labels
None yet
Projects
None yet
Milestone
v1.0.0
Development

Successfully merging this pull request may close these issues.

Remove WP_Mock/Loader
4 participants
@unfulvio-godaddy @coveralls @agibson-godaddy @jeffpaul