Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Should setWatchJavaScriptDependencies(true) traversing through node_modules ? #375

Closed
okitavera opened this issue Jan 11, 2019 · 2 comments
Closed

Should setWatchJavaScriptDependencies(true) traversing through node_modules ? #375

okitavera opened this issue Jan 11, 2019 · 2 comments
Labels
bug high-priority
Milestone
0.7.1

Comments

@okitavera
Copy link

It almost takes a half of minutes to get the BrowserSync fired
I don't know if it's normal or not.

DEBUG=* eleventy --serve

Also, my environment is

  • Eleventy 0.7.0
  • Node v11.6.0
  • Archlinux
@zachleat zachleat added the bug label Jan 11, 2019
@zachleat
Copy link
Member

Hmm, this is way costlier than I’d like but I think it’s a mistake on my end. I’m filtering the dependencies at the end and not using dependency-tree’s internal filter feature, which seems to be much faster. Sorry about that!

@zachleat zachleat added this to the 0.7.1 milestone Jan 11, 2019
@zachleat
Copy link
Member

This will ship with 0.7.1. Also added a benchmark warning on it.

okitavera added a commit to okitavera/okitavera.netlify.app that referenced this issue Jan 12, 2019
@okitavera
closes 11ty/eleventy#375
f335ebd
@aakoch aakoch mentioned this issue Jan 16, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug high-priority
Projects
None yet
Milestone
0.7.1
Development

No branches or pull requests
2 participants
@zachleat @okitavera