Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump chokidar to v4 #3445

Closed
wants to merge 1 commit into from
Closed

Conversation

talentlessguy
Copy link

@talentlessguy talentlessguy commented Sep 15, 2024

Removes 11 dependencies, includes better types

Passes all tests

Draft for now because needs bumping in dev-server as well

@zachleat
Copy link
Member

Sorry—we can’t do this yet per notes made at #3442. Clearly we need some additional test coverage there

@zachleat zachleat closed this Sep 16, 2024
@talentlessguy
Copy link
Author

is it okay if I add tests with a glob matcher (using fast-glob which is already a dependency) or it's still a no?

@zachleat
Copy link
Member

oh, yeah for sure! The plan is to upgrade to v4, internally we rely on that globs feature so we’d need to make sure that doesn’t break when we upgrade. Some more notes on that here: https://www.11ty.dev/docs/watch-serve/#add-your-own-watch-targets

@talentlessguy
Copy link
Author

how would a test for it look like? should I use fixtures for it?

@talentlessguy talentlessguy deleted the chokidar-v4 branch September 18, 2024 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants