Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: add stub file of cm.py and script that generates it #112

Merged
merged 2 commits into from
Dec 21, 2023
Merged

ENH: add stub file of cm.py and script that generates it #112

merged 2 commits into from
Dec 21, 2023

Conversation

beskep
Copy link
Contributor

@beskep beskep commented Dec 20, 2023

No description provided.

@neutrinoceros
Copy link
Collaborator

for posterity: replaces #111 and fixes #110

@neutrinoceros neutrinoceros linked an issue Dec 20, 2023 that may be closed by this pull request
@neutrinoceros
Copy link
Collaborator

Looks good, but you'll also need to make sure type-checking tests are passing. Actually it seems that most errors are "unused ignore comment" so that's great; please remove such comments and deal with other errors.

You may run the check locally as

$ python -m pip install -r requirements/typecheck.txt
$ python -m mypy cmasher

@beskep
Copy link
Contributor Author

beskep commented Dec 20, 2023

I haven't thought about that could cause a type checking error.

Also fixed implicit-str-concat warning that pylint was complaining about.

Copy link

codecov bot commented Dec 21, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (4c7f09f) 98.36% compared to head (0f42df5) 98.36%.

Additional details and impacted files
@@           Coverage Diff           @@
##              dev     #112   +/-   ##
=======================================
  Coverage   98.36%   98.36%           
=======================================
  Files           6        6           
  Lines         611      611           
=======================================
  Hits          601      601           
  Misses         10       10           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@neutrinoceros
Copy link
Collaborator

Good job, and congrats on your first merged PR ! 🎉

@neutrinoceros neutrinoceros merged commit 478859e into 1313e:dev Dec 21, 2023
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adding stub file of cm.py
2 participants