Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MNT: upgrade uv.lock (pyqt5-qt5 5.15.5, pyqt5-sip 12.16.1) #188

Closed
wants to merge 1 commit into from

Conversation

neutrinoceros
Copy link
Collaborator

This is obtained by uv lock --upgrade and two changes happened since the affected portions of the lock file were last updated:

I have not examined each change in detail yet, so I want to take the upgrade for a spin on CI to learn if it's even worth doing or necessary.

@neutrinoceros neutrinoceros added the dependencies Pull requests that update a dependency file label Dec 14, 2024
@neutrinoceros
Copy link
Collaborator Author

Evidently this doesn't work out of the box. Maybe I need to explicitly opt-in the old default behavior instead.

@neutrinoceros
Copy link
Collaborator Author

that's not it. --fork-strategy=fewest or --fork-strategy=requires-python produce similar results. Maybe that's a regression in uv 0.5.9 then. I'll try to report upstream if I have time soon.

@neutrinoceros
Copy link
Collaborator Author

I've come around to pinning uv itself in #189, which hopefully will help disentangling this situation

@neutrinoceros
Copy link
Collaborator Author

I checked that

  • uv.lock is not updated if I remove the --upgrade flag, regardless if I use uv 0.5.8 or 0.5.9
  • uv 0.5.8 generates the exact same lock file if running from scratch

This means that the breaking change must be caused by some external factor, most likely by a newly dropped release of one (or more ?) packages that this lock file keeps track of. PyQt5-sip 12.16.1 is an obvious suspect here.

@neutrinoceros
Copy link
Collaborator Author

I just remembered that I originally wrote the forked dependencies in pyproject.toml manually and generated uv.lock with these constraints. See https://github.com/1313e/CMasher/pull/181/files#diff-50c86b7ed8ac2cf95bd48334961bf0530cdc77b5a56f852c5c61b89d735fd711

This means that uv lock may actually never have done the right thing on its own here. I'll definitely need to report upstream.

@neutrinoceros
Copy link
Collaborator Author

reported as astral-sh/uv#9907

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant