This repository was archived by the owner on Sep 19, 2021. It is now read-only.
Release 07/16/2018 #561
Merged
Release 07/16/2018 #561
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
don't collect coverage when running Jest by default
add information about the technologies used
DRY the navigation components
Having the log message output to the console is noisy, and not helpful if not dealing with Redux. Switched to using the browser extension, which has more features.
Merge in 372-electronic-signatures
use the Redux DevTools Extension for troubleshooting
In the [docs for the Digital Analytics Program](https://github.com/digital-analytics-program/gov-wide-code#appropriate-placement), they say that "the DAP script tag should not be placed on pages visited during logged-in sessions". The only pages where the user isn't logged in are the consent form and the login form, the latter of which we probably don't want an external script on anyway. Removing DAP for now, at least until there's a more extensive landing page and other unauthenticated parts of the site.
Fixes for printing and instruction to reset locked form
Previously, all requests (to somewhere other than `/api/*`) would return a 200. Now, nginx will give a 404 when making a request with an extension, such as `*.js` or `*.css`. New behavior: ``` $ curl -I http://localhost:8080/ HTTP/1.1 200 OK ... $ curl -I http://localhost:8080/foo HTTP/1.1 200 OK ... $ curl -I http://localhost:8080/eqip.js HTTP/1.1 200 OK ... $ curl -I http://localhost:8080/foo.js HTTP/1.1 404 Not Found ... ```
remove DAP
render the index number in the residence, employment, and school lists
give 404s when requesting a file that doesn't exist
move Dockerfiles and Cloud Foundry manifests out of top-level directory
Updating content
remove 2FA code
move from Glide to Dep for managing API dependencies
fail build if there are any golint errors
unignore the bin directory
remove QR code-related packages
Fixes `To use go native vendoring set the $GOPACKAGENAME` error and `Unable to determine import path: GOPACKAGENAME unset`.
Fixes go buildpack error on cloud.gov deploy
This will help resolve discrepancies between development and production building of the API - in this case, Go dependencies weren't being installed. This should fix the AWS deploy.
use Docker Compose for building the API
move errorReducer to its own file
|
Holding off merge until Snyk reports are reviewed/triaged #563 – Snyk is currently only evaluating the deltas on a commit, and I think this is the first time we've seen a more comprehensive report. |
|
Worth noting that those findings aren't a regression, i.e. the last tagged release will likely have as many or more of the same issues, as the dependencies haven't been updated in a while. |
|
Proceeding with merge – nothing in Snyk report affects the app while deployed, just modules that aren't used, or used during linting/testing/etc. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.