Removes unused packages as reported by depcheck #568
Conversation
Evaluted unused dependencies reported by `depcheck`; filtered out those that had references in `webpack.config.js`, `gulpfile.js`, `eqip.scss`, and `package.json` blocks (excluding `dependencies`). and `gulpfile.js`
package.json
Outdated
| @@ -17,42 +17,33 @@ | |||
| "@18f/stylelint-rules": "^2.0.0", | |||
| "axios": "^0.18.0", | |||
| "axios-mock-adapter": "^1.15.0", | |||
| "babel-core": "^6.26.3", | |||
| "babel-jest": "^23.0.1", | |||
There was a problem hiding this comment.
Yarn figures out that we need it – do we need to put it as a top-level dependency?
There was a problem hiding this comment.
(i.e., jest pulls it in, so does babel-loader)
There was a problem hiding this comment.
➜ e-QIP-prototype git:(remove-unused) yarn
yarn install v1.7.0
[1/5] 🔍 Resolving packages...
[2/5] 🚚 Fetching packages...
[3/5] 🔗 Linking dependencies...
warning " > [email protected]" has unmet peer dependency "babel-core@6".
...
There was a problem hiding this comment.
Good to go after that's re-added!
There was a problem hiding this comment.
Note there's another package.json, but those are just for running integration tests.
package.json
Outdated
| @@ -17,42 +17,33 @@ | |||
| "@18f/stylelint-rules": "^2.0.0", | |||
| "axios": "^0.18.0", | |||
| "axios-mock-adapter": "^1.15.0", | |||
| "babel-core": "^6.26.3", | |||
| "babel-jest": "^23.0.1", | |||
There was a problem hiding this comment.
Good to go after that's re-added!
|
Thanks! I had somehow missed that warning. After reading yarnpkg/yarn#5347 I've realized yarn's dependency management was different than what I was expecting. Not touching the spec tests since they aren't working yet. Did this clean up to address some of the "high" severity items in the Synk report on #563 |
It's A Feature 😉 |
Evaluted unused dependencies reported by
depcheck; filtered outthose that had references in
webpack.config.js,gulpfile.js,eqip.scss, andpackage.jsonblocks (excludingdependencies).and
gulpfile.js