Skip to content
This repository has been archived by the owner on Apr 12, 2024. It is now read-only.

Remove CodeCov, add CodeQL on GitHub #273

Merged
merged 2 commits into from
Jul 14, 2021
Merged

Remove CodeCov, add CodeQL on GitHub #273

merged 2 commits into from
Jul 14, 2021

Conversation

ryanhofdotgov
Copy link
Contributor

@ryanhofdotgov ryanhofdotgov commented Jul 14, 2021 •
edited
Loading

CodeCov is not approved for use (no GSA ATO, not in GEAR). CodeQL is approved by virtue of it being part of GitHub.

@github-actions
Copy link

Pa11y testing results 
> [email protected] pa11y-ci:sitemap /home/runner/work/development-guide/development-guide
> pa11y-ci --sitemap https://engineering.18f.gov/sitemap.xml --sitemap-find https://engineering.18f.gov --sitemap-replace http://localhost:4000 --sitemap-exclude "/*.pdf"

Running Pa11y on 39 URLs:
(node:2923) UnhandledPromiseRejectionWarning: Error: Page crashed!
    at Page._onTargetCrashed (/home/runner/work/development-guide/development-guide/node_modules/puppeteer/lib/Page.js:215:24)
    at CDPSession.<anonymous> (/home/runner/work/development-guide/development-guide/node_modules/puppeteer/lib/Page.js:123:56)
    at CDPSession.emit (events.js:375:28)
    at CDPSession._onMessage (/home/runner/work/development-guide/development-guide/node_modules/puppeteer/lib/Connection.js:200:12)
    at Connection._onMessage (/home/runner/work/development-guide/development-guide/node_modules/puppeteer/lib/Connection.js:112:17)
    at WebSocket.<anonymous> (/home/runner/work/development-guide/development-guide/node_modules/puppeteer/lib/WebSocketTransport.js:44:24)
    at WebSocket.onMessage (/home/runner/work/development-guide/development-guide/node_modules/ws/lib/event-target.js:120:16)
    at WebSocket.emit (events.js:375:28)
    at Receiver.receiverOnMessage (/home/runner/work/development-guide/development-guide/node_modules/ws/lib/websocket.js:789:20)
    at Receiver.emit (events.js:375:28)
(Use `node --trace-warnings ...` to show where the warning was created)
(node:2923) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). To terminate the node process on unhandled promise rejection, use the CLI flag `--unhandled-rejections=strict` (see https://nodejs.org/api/cli.html#cli_unhandled_rejections_mode). (rejection id: 1)
(node:2923) [DEP0018] DeprecationWarning: Unhandled promise rejections are deprecated. In the future, promise rejections that are not handled will terminate the Node.js process with a non-zero exit code.
 > http://localhost:4000/architecture-reviews/micro-purchase/ - 0 errors
 > http://localhost:4000/architecture-reviews/ - 0 errors
 > http://localhost:4000/accessibility-scanning/ - 0 errors
 > http://localhost:4000/browser-testing/ - 0 errors
 > http://localhost:4000/code-review/ - 0 errors
 > http://localhost:4000/continuous-deployment/ - 0 errors
 > http://localhost:4000/datastore-selection/ - 0 errors
 > http://localhost:4000/development-environments/ - 0 errors
 > http://localhost:4000/css/ - 0 errors
 > http://localhost:4000/docker/ - 0 errors
 > http://localhost:4000/example-workflows/ - 0 errors
 > http://localhost:4000/frontend/ - 0 errors
 > http://localhost:4000/incident-reports/ - 0 errors
 > http://localhost:4000/incident-reports/cloud-gov/ - 0 errors
 > http://localhost:4000/ - 0 errors
 > http://localhost:4000/integrations/ - 0 errors
(node:2923) UnhandledPromiseRejectionWarning: Error: Page crashed!
    at Page._onTargetCrashed (/home/runner/work/development-guide/development-guide/node_modules/puppeteer/lib/Page.js:215:24)
    at CDPSession.<anonymous> (/home/runner/work/development-guide/development-guide/node_modules/puppeteer/lib/Page.js:123:56)
    at CDPSession.emit (events.js:375:28)
    at CDPSession._onMessage (/home/runner/work/development-guide/development-guide/node_modules/puppeteer/lib/Connection.js:200:12)
    at Connection._onMessage (/home/runner/work/development-guide/development-guide/node_modules/puppeteer/lib/Connection.js:112:17)
    at WebSocket.<anonymous> (/home/runner/work/development-guide/development-guide/node_modules/puppeteer/lib/WebSocketTransport.js:44:24)
    at WebSocket.onMessage (/home/runner/work/development-guide/development-guide/node_modules/ws/lib/event-target.js:120:16)
    at WebSocket.emit (events.js:375:28)
    at Receiver.receiverOnMessage (/home/runner/work/development-guide/development-guide/node_modules/ws/lib/websocket.js:789:20)
    at Receiver.emit (events.js:375:28)
(node:2923) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). To terminate the node process on unhandled promise rejection, use the CLI flag `--unhandled-rejections=strict` (see https://nodejs.org/api/cli.html#cli_unhandled_rejections_mode). (rejection id: 2)
 > http://localhost:4000/language-selection/ - 0 errors
 > http://localhost:4000/javascript/ - 0 errors
 > http://localhost:4000/license/ - 0 errors
 > http://localhost:4000/markdown/ - 0 errors
 > http://localhost:4000/nodejs/ - 0 errors
 > http://localhost:4000/people/ - 0 errors
 > http://localhost:4000/people/assessment/ - 0 errors
 > http://localhost:4000/project-setup/ - 0 errors
 > http://localhost:4000/release-strategies/ - 0 errors
 > http://localhost:4000/python/ - 0 errors
 > http://localhost:4000/resources/ - 0 errors
 > http://localhost:4000/ruby/ - 0 errors
 > http://localhost:4000/security/ - 0 errors
 > http://localhost:4000/security/cloud-services/ - 0 errors
 > http://localhost:4000/security/content-security-policy/ - 0 errors
 > http://localhost:4000/security/dependency-remediation/ - 0 errors
 > http://localhost:4000/security/incident-response-drills/ - 0 errors
 > http://localhost:4000/security/output-encoding/ - 0 errors
 > http://localhost:4000/sharepoint/ - 0 errors
 > http://localhost:4000/web-architecture/ - 0 errors
 > http://localhost:4000/workflow/ - 0 errors
 > http://localhost:4000/architecture-reviews/data-act-pilot/ - Failed to run
 > http://localhost:4000/laptop-setup/ - Failed to run

Errors in http://localhost:4000/architecture-reviews/data-act-pilot/:

 • Error: Pa11y timed out (30000ms)

Errors in http://localhost:4000/laptop-setup/:

 • Error: Pa11y timed out (30000ms)

✘ 37/39 URLs passed
npm ERR! code ELIFECYCLE
npm ERR! errno 2
npm ERR! [email protected] pa11y-ci:sitemap: `pa11y-ci --sitemap https://engineering.18f.gov/sitemap.xml --sitemap-find https://engineering.18f.gov --sitemap-replace http://localhost:4000 --sitemap-exclude "/*.pdf"`
npm ERR! Exit status 2
npm ERR! 
npm ERR! Failed at the [email protected] pa11y-ci:sitemap script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.

npm ERR! A complete log of this run can be found in:
npm ERR!     /home/runner/.npm/_logs/2021-07-14T17_59_10_016Z-debug.log

@ryanhofdotgov
Downgrade CodeQL from standard to default
d8db71d 
Before-you-ship indicates other solutions and CodeQL is not yet applied
universally as "standard" would suggest.
@github-actions
Copy link

Pa11y testing results 
> [email protected] pa11y-ci:sitemap /home/runner/work/development-guide/development-guide
> pa11y-ci --sitemap https://engineering.18f.gov/sitemap.xml --sitemap-find https://engineering.18f.gov --sitemap-replace http://localhost:4000 --sitemap-exclude "/*.pdf"

Running Pa11y on 39 URLs:
 > http://localhost:4000/architecture-reviews/ - 0 errors
 > http://localhost:4000/architecture-reviews/data-act-pilot/ - 0 errors
 > http://localhost:4000/architecture-reviews/micro-purchase/ - 0 errors
 > http://localhost:4000/accessibility-scanning/ - 0 errors
 > http://localhost:4000/continuous-deployment/ - 0 errors
 > http://localhost:4000/browser-testing/ - 0 errors
 > http://localhost:4000/code-review/ - 0 errors
 > http://localhost:4000/datastore-selection/ - 0 errors
 > http://localhost:4000/example-workflows/ - 0 errors
 > http://localhost:4000/css/ - 0 errors
 > http://localhost:4000/development-environments/ - 0 errors
 > http://localhost:4000/docker/ - 0 errors
 > http://localhost:4000/incident-reports/ - 0 errors
 > http://localhost:4000/incident-reports/cloud-gov/ - 0 errors
 > http://localhost:4000/frontend/ - 0 errors
 > http://localhost:4000/ - 0 errors
 > http://localhost:4000/integrations/ - 0 errors
 > http://localhost:4000/language-selection/ - 0 errors
 > http://localhost:4000/license/ - 0 errors
 > http://localhost:4000/laptop-setup/ - 0 errors
 > http://localhost:4000/javascript/ - 0 errors
 > http://localhost:4000/people/ - 0 errors
 > http://localhost:4000/markdown/ - 0 errors
 > http://localhost:4000/people/assessment/ - 0 errors
 > http://localhost:4000/nodejs/ - 0 errors
 > http://localhost:4000/python/ - 0 errors
 > http://localhost:4000/project-setup/ - 0 errors
 > http://localhost:4000/resources/ - 0 errors
 > http://localhost:4000/release-strategies/ - 0 errors
 > http://localhost:4000/ruby/ - 0 errors
 > http://localhost:4000/security/cloud-services/ - 0 errors
 > http://localhost:4000/security/content-security-policy/ - 0 errors
 > http://localhost:4000/security/ - 0 errors
 > http://localhost:4000/security/dependency-remediation/ - 0 errors
 > http://localhost:4000/security/incident-response-drills/ - 0 errors
 > http://localhost:4000/sharepoint/ - 0 errors
 > http://localhost:4000/security/output-encoding/ - 0 errors
 > http://localhost:4000/web-architecture/ - 0 errors
 > http://localhost:4000/workflow/ - 0 errors

✔ 39/39 URLs passed

alexsoble
alexsoble approved these changes Jul 14, 2021
View reviewed changes
Copy link
Contributor

@alexsoble alexsoble left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A good change! Should we say a little bit about why?

@ryanhofdotgov
Copy link
Contributor Author

Oops – thanks – I edited the PR comment to cover the "why" of the change.

@ryanhofdotgov ryanhofdotgov merged commit bb4091f into main Jul 14, 2021
@ryanhofdotgov ryanhofdotgov deleted the rmh-update-project-recs branch July 14, 2021 18:41
This was referenced Jul 14, 2021
Closed
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@alexsoble alexsoble alexsoble approved these changes

@Sgtpluck Sgtpluck Awaiting requested review from Sgtpluck

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ryanhofdotgov @alexsoble