Replace sassc-rails with cssbundling-rails + sass #5862
Conversation
**Why**: - Hopefully faster - No more segfaults - Avoid [deprecated](https://sass-lang.com/libsass) LibSass - Using Dart Sass opens up access to new features - Alignment to new Rails 7 defaults, and companion to jsbundling-rails
| sassc (2.4.0) | ||
| ffi (~> 1.9) |
| @@ -50,7 +50,7 @@ | |||
| line-height: 1.5; | |||
| // For content to appear as vertically centered, offset the larger line-height of the banner to | |||
| // match the space below the drag text. | |||
| margin-top: ((1.5rem - size('body', '2xs')) - ((1.625rem * 1.5) - 1.625rem)) / 2; | |||
| margin-top: ((1.5rem - size('body', '2xs')) - ((1.625rem * 1.5) - 1.625rem)) * 0.5; | |||
There was a problem hiding this comment.
was this an int vs float issue?
There was a problem hiding this comment.
Slash as division is deprecated in Sass, so this is just to avoid noisy deprecation messages.
https://sass-lang.com/documentation/breaking-changes/slash-div
There was a problem hiding this comment.
Now that we're on Dart Sass, we could alternatively swap it with the new math module function, as in d492148.
see what the performance trade-off is
|
Looks like it's working okay in my sandbox. 👍 While there's a small performance penalty, but I think we'll need to go with
I did notice one issue I'll need to resolve, which is that |
aduth
changed the title
These are helpers added by |
Inline watch handling to avoid dealing with tuple results of Promise.all
Why: