Catch up to master's clone-cleanups #107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changed `getDefaultStyle` to create the element in the sandbox so it is pure (not tainted by CSS / ShadowDOM in the main document). Never clone SCRIPT elements (that's just asking for trouble). Removed `imagediff` package as it's not useful anymore.
The allows inspecting the properties of the clone.
Removed the setting of the `top` and `left` Set the `width` and `height` on the `foreignObject` element to the target size. Removed setting of `width` and `height` on the `svg` element.
Falls back to the old `scrollWidth`/`scrollHeight` logic if the `width` and `height` aren't set in `px`.
* Work on table padding issue #95 Changed `getDefaultStyle` to create the element in the sandbox so it is pure (not tainted by CSS / ShadowDOM in the main document). Never clone SCRIPT elements (that's just asking for trouble). Removed `imagediff` package as it's not useful anymore. * Add ability to insert the cloned node into the test The allows inspecting the properties of the clone. * Simplified the SVG Removed the setting of the `top` and `left` Set the `width` and `height` on the `foreignObject` element to the target size. Removed setting of `width` and `height` on the `svg` element. * Copy the size from the original object when possible Falls back to the old `scrollWidth`/`scrollHeight` logic if the `width` and `height` aren't set in `px`. * Revert to have `width` and `height` dimensions on SVG object.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.