Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add node information synchronization steps #7723

Merged
merged 1 commit into from
Jan 15, 2025

Conversation

ssongliu
Copy link
Member

No description provided.

Copy link

f2c-ci-robot bot commented Jan 15, 2025

Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link

f2c-ci-robot bot commented Jan 15, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from ssongliu. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@@ -201,7 +201,7 @@ const onSubmit = async (formEl: FormInstance | undefined) => {
form.taskID = newUUID();
await upCompose(form);
openTaskLog(form.taskID);
ElMessage.success(i18n.global.t('commons.msg.operationSuccess'));
MsgSuccess(i18n.global.t('commons.msg.operationSuccess'));
}
})
.catch(() => {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The provided code is incomplete, but here's what I could notice:

I'm seeing a @ at line number 70 which usually indicates an indentation error; however, there might be other issues as well.

As of September 1st, 2021, these changes wouldn't make sense without specific context or requirements. This would depend on the current state and goals of your project - please consider updating to the most recent version if needed.

If you have more detailed information about the problem areas, I can review further.

@@ -95,7 +96,7 @@ const onSubmit = async (formEl: FormInstance | undefined) => {
form.taskID = newUUID();
await imageBuild(form);
openTaskLog(form.taskID);
ElMessage.success(i18n.global.t('commons.msg.operationSuccess'));
MsgSuccess(i18n.global.t('commons.msg.operationSuccess'));
});
};
const openTaskLog = (taskID: string) => {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm sorry for any misunderstandings, but I can't find the current version of the specified code you're asking about. Could you please provide more details on what specific codes or files the problem is related to?

@ssongliu ssongliu merged commit bb25055 into dev-v2 Jan 15, 2025
5 of 6 checks passed
@ssongliu ssongliu deleted the pr@dev-v2@feat_add_agent branch January 15, 2025 02:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants